Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RAID cli commands into a 'raid' subcommand #18

Merged
merged 22 commits into from
Apr 6, 2023
Merged

Refactor RAID cli commands into a 'raid' subcommand #18

merged 22 commits into from
Apr 6, 2023

Conversation

splaspood
Copy link
Collaborator

@splaspood splaspood commented Jan 30, 2023 •
edited
Loading

  • Move all raid related commands under a 'raid' subcommand
  • Add VirtualDisk listing support
  • Add PhysicalDisk listing support

@splaspood splaspood marked this pull request as draft January 30, 2023 14:34
@splaspood splaspood marked this pull request as ready for review February 6, 2023 20:18
joelrebel
joelrebel requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, left a few suggestions.

cmd/raid.go Outdated Show resolved Hide resolved
pkg/model/raid_array.go Outdated Show resolved Hide resolved
pkg/model/raid_array.go Outdated Show resolved Hide resolved
joelrebel
joelrebel previously approved these changes Mar 6, 2023
View reviewed changes
@splaspood splaspood requested a review from joelrebel March 7, 2023 11:57
@splaspood splaspood force-pushed the raid-subcmd-0 branch 6 times, most recently from 4fa116c to cc86baf Compare April 3, 2023 15:25
@splaspood
Refactor RAID cli commands into a 'raid' subcommand, add raid device …
5c6a338 
…listing
@splaspood
Implement PhysicalDisk listing support for raid-type==hardware
819851b
@splaspood
Bump version to 0.2.3
b47a7a0
@splaspood
pkg/model/raid_array.go: Simplify listPhysicalDisksHardware()
f378f97
@splaspood
pkg/model/raid_array.go: Remove redundant error check from getironlib…
8ff0557 
…Inventory()
@splaspood
cmd/raid.go: Remove default handling from getRaidType()
66308b7
@splaspood
cmd/raid.go, cmd/raid_list.go: Remove unnecessary getRaidObjectType()
02c3e4b
@splaspood
cmd/raid*.go: Remove unnecessary getRaidType()
3d034ed
@splaspood
pkg/model/raid_array.go: Use new ironlib Options
19ddb85
@splaspood
.github/workflows/goreleaser.yml: Use goreleaser-action v4.2.0
5f22108
@splaspood
go.mod, go.sum: Update ironlib to latest 0.2.5
52b3668
@splaspood
Remove docker related goreleaser settings
581a068
@splaspood
go.mod, go.sum: Upgrade to ironlib v0.2.5
3d6149f
@splaspood
pkg/model/raid_array.go: Enable TRACE logging for ironlib
1d29ba5
joelrebel
joelrebel approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@splaspood splaspood merged commit de1fa69 into main Apr 6, 2023
@splaspood splaspood deleted the raid-subcmd-0 branch April 6, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelrebel joelrebel joelrebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@splaspood @joelrebel