Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Dockerfile updates #38

Merged
merged 5 commits into from
May 10, 2023
Merged

Some Dockerfile updates #38

merged 5 commits into from
May 10, 2023

Conversation

mmlb
Copy link
Member

@mmlb mmlb commented May 10, 2023 •
edited
Loading

  • Separate the ironlib base image tag so we can use one thats available publicly by default.
  • Update ironlib base image.
  • Added a dependencies empty dir so that docker build would work on a fresh checkout.
  • Squashed vogelkop image so its minimal amount of images. Doesn't really do much for this image except for minimize output of docker load, but its nice to have anyway imo.

@mmlb mmlb requested a review from splaspood May 10, 2023 15:07
mmlb added 5 commits May 10, 2023 11:37
@mmlb
Take ironlib image tag as a build arg
8859343 
Maybe we want a IRONLIB_IMAGE instead of 2 tags though.
@mmlb
Update ironlib image to latest
0b638c0 
I was getting unknown manifest errors for the original image, might as well
update to latest while we're here too.
@mmlb
Create an empty dependencies dir so docker build works
eb9f6c3 
Would be great to not have to do any undocumented steps to get a build after
a fresh clone.
@mmlb
COPY and chmod in one command
cb96f89 
Drops a layer, :toot:.
@mmlb
Build final image based off scratch
feb0d23 
This way any layers in ironlib are squashed into just one.
@mmlb mmlb merged commit fc4a70a into main May 10, 2023
@mmlb mmlb deleted the squash-vogelkop-image branch May 10, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splaspood splaspood splaspood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmlb @splaspood