-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Allow BMC address to be updated #1549
Conversation
/test metal3-bmo-e2e-test-pull |
/test-centos-e2e-integration-main |
Finally jenkins woke up |
For the record, here is the original one with reviews and discussions: #1532 |
/lgtm |
cb3fd22
to
bb8c2a7
Compare
28aa2b5
to
67e5290
Compare
/test metal3-bmo-e2e-test-pull |
Allow BMC address to be updated if the BMH is in the Registering state or if it is detached. Signed-off-by: Mahnoor Asghar <masghar@redhat.com>
/test metal3-bmo-e2e-test-pull |
/test-centos-e2e-integration-main |
} | ||
if !reflect.DeepEqual(newAddress, ironicAddress) { | ||
bmcAddressChanged = true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
bmcAddressChanged := !reflect.DeepEqual(newAddress, ironicAddress)
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test-centos-e2e-integration-main |
Allow BMC address to be updated if the BMH is in the Registering state or is detached.
This allows the BMC address to be updated if there are changes in the BMC network, or if a mistake was made when setting it the first time.
Fixes #1458