🌱 E2E: Fix basic auth config #1556
Conversation
metal3-io-bot
added
the
size/XS
The variables used for setting basic auth credentials were not exported, meaning that envsubst did not pick them up. This caused the auth config to have empty values. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
lentzi90
force-pushed
the
lentzi90/e2e-basic-auth-fix
branch
from
3de3587 to
4458b11
Compare
|
/test metal3-bmo-e2e-test-pull |
|
/test-centos-e2e-integration-main |
|
LGTM |
|
lgtm |
Shouldn't the test fail/complain in such case ? |
My understanding is that empty auth config for Ironic is the same as disabling basic auth. That does not make the tests fail since everything still works, it is just insecure. BMO was all the time configured with credentials but those were not needed since Ironic didn't ask for any. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, mboukhalfa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
What this PR does / why we need it:
The variables used for setting basic auth credentials were not exported, meaning that envsubst did not pick them up. This caused the auth config to have empty values.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #