Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 release-0.5: harden stable branch against inspector removal #1562

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

dtantsur
Copy link
Member

  • Use ironic-image release-24.0 which still has Inspector support
  • Explicitly enable Inspector in all environment files

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2024
- Use ironic-image release-24.0 which still has Inspector support
- Explicitly enable Inspector in all environment files

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@dtantsur
Copy link
Member Author

/test-centos-e2e-integration-release-1-6
/test-ubuntu-integration-release-1-6

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I think it makes sense to pin ironic like this

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-release-1-6

Copy link
Member

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtantsur
Copy link
Member Author

/cc @kashifest

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@metal3-io-bot metal3-io-bot merged commit 9ec1c3d into metal3-io:release-0.5 Feb 26, 2024
16 checks passed
@dtantsur dtantsur deleted the no-inspector-0.5 branch February 27, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants