-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 release-0.5: harden stable branch against inspector removal #1562
🌱 release-0.5: harden stable branch against inspector removal #1562
Conversation
dtantsur
commented
Feb 21, 2024
- Use ironic-image release-24.0 which still has Inspector support
- Explicitly enable Inspector in all environment files
b4afb94
to
1687575
Compare
- Use ironic-image release-24.0 which still has Inspector support - Explicitly enable Inspector in all environment files Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
1687575
to
b074083
Compare
/test metal3-bmo-e2e-test-pull |
/test-centos-e2e-integration-release-1-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think it makes sense to pin ironic like this
/test-ubuntu-integration-release-1-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @kashifest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |