🌱 Add unit test on pkg/provisioner/ironic/client.go

[lekaf974]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1574

[metal3-io-bot]

Hi @lekaf974. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lekaf974]

Hi, I started to add unit test but not sure that those implemented make sense to you.
Could you have a look and give feedback to see if I am on the good way ?

Thx

[tuminoid]

/ok-to-test

[lekaf974]

Added minimal tests on updateHTTPClient
Like I say let me know if we want more specific tests

[lentzi90]

/cc @lentzi90
So that I don't forget about it. I will probably not have time to review it the next couple of weeks though.

[lekaf974]

@dtantsur Updated the unit test, waiting for feedback

[lentzi90]

Thank you!
/lgtm

[lentzi90]

/test metal3-bmo-e2e-test-pull
/test test-centos-e2e-integration-main

[lentzi90]

/test-centos-e2e-integration-main

[lekaf974]

@lentzi90 anything else needs to be done to merge this one ?

[lentzi90]

Oh, looks like we just forgot about this. We need someone to approve it. I will tag some who can.
/cc @kashifest @dtantsur

[lentzi90]

/test metal3-centos-e2e-integration-test-main

[tuminoid]

@kashifest PTAL, this seems ready for approval.

[kashifest]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment