Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Improve deploy.sh to differentiate between build and run of kustomize #1622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CJCShadowsan
Copy link

What this PR does / why we need it:

Currently deploy.sh tries to use ${SCRIPTDIR} in its KUSTOMIZE variable which breaks calling it via the Makefile to build kustomize in some cases (it certainly does on my system!). To fix, I added another variable, KUSTOMIZE_BUILD which points to exactly what the Makefile wants to see.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Chris Coates <christopher.james.coates@gmail.com>
@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2024
@metal3-io-bot
Copy link
Contributor

Hi @CJCShadowsan. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2024
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2024
@tuminoid
Copy link
Member

/test-centos-e2e-integration-main

@tuminoid
Copy link
Member

/cc @kashifest

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2024
@Rozzii
Copy link
Member

Rozzii commented Jun 28, 2024

/remove-lifecycle stale

@Rozzii
Copy link
Member

Rozzii commented Jun 28, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@Rozzii
Copy link
Member

Rozzii commented Jun 28, 2024

/cc @elfosardo

@Rozzii
Copy link
Member

Rozzii commented Jun 28, 2024

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2024
@Rozzii Rozzii added this to the BMO - v0.7.0 milestone Jun 28, 2024
@@ -110,7 +110,8 @@ mkdir -p "${TEMP_BMO_OVERLAY}"
mkdir -p "${TEMP_IRONIC_OVERLAY}"

KUSTOMIZE="${SCRIPTDIR}/tools/bin/kustomize"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can be done in a follow up but if you invert the lines between KUSTOMIZE and KUSTOMIZE_BUILD you can reuse the latter to build the former

@elfosardo
Copy link
Member

/approve
not sure I can approve here :/

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elfosardo
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rozzii
Copy link
Member

Rozzii commented Jul 1, 2024

/cc @zaneb

@metal3-io-bot metal3-io-bot requested a review from zaneb July 1, 2024 13:17
@Rozzii Rozzii modified the milestones: BMO - v0.6.2, BMO - v0.7.0 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: BMO WIP
Development

Successfully merging this pull request may close these issues.

5 participants