✨ Add nonbootable iso api #1623
Conversation
metal3-io-bot
added
the
size/L
|
|
||
| // DataImageSpec defines the desired state of DataImage. | ||
| type DataImageSpec struct { | ||
| // Important: Run "make" to regenerate code after modifying this file |
| } | ||
|
|
||
| //+kubebuilder:object:root=true | ||
| //+kubebuilder:resource:shortName=dimg |
There was a problem hiding this comment.
It's going to be a very rarely used resource, let's maybe not have a short name for it?
|
The previous PR modifies a few more API-related files, such as config/base/crds/kustomization.yaml, a sample or RBAC roles. Could you add them too? |
Signed-off-by: Himanshu Roy <hroy@redhat.com>
Signed-off-by: Himanshu Roy <hroy@redhat.com>
hroyrh
force-pushed
the
nonbootable-iso-api
branch
from
9b13e0e to
5809f3e
Compare
…ple dataimage resource file Signed-off-by: Himanshu Roy <hroy@redhat.com>
hroyrh
force-pushed
the
nonbootable-iso-api
branch
from
767a5d0 to
5815817
Compare
|
@dtantsur I have updated the base kustomization config, and added cainjection, webhook and sample dataimage resource file. I've left the RBAC configs since they depend on the controller and it will be more appropriate to include them in the other pr. |
|
/test metal3-bmo-e2e-test-pull |
|
/test-centos-e2e-integration-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
What this PR does / why we need it:
This PR defines the API for attaching and detaching non-bootable iso image. The Controller implementation for the API is in progress in this pr : #1594