Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 backported fixes for Makefile and release workflow #1693

Merged

Conversation

tuminoid
Copy link
Member

Basically a cherry-pick from CAPM3 PR #1567 originally, and manual cherry-pick of BMO PR #1636 for the release workflow / release note generator.

Support beta and RC releases in release note generator. Move some logic from Makefile to the release note generator, and then add nice unfolding summary section to hide details in beta/rc notes.

Fix previous release tag pattern detection in Makefile.

Basically a cherry-pick from CAPM3 PR metal3-io#1567.

Support beta and RC releases in release note generator. Move some logic
from Makefile to the release note generator, and then add nice unfolding
summary section to hide details in beta/rc notes.

Fix previous release tag pattern detection in Makefile.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2024
@tuminoid
Copy link
Member Author

/override metal3-bmo-e2e-test-pull test-centos-e2e-integration-release-1-6 test-ubuntu-integration-release-1-6
/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 23, 2024
@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-release-1-6, test-ubuntu-integration-release-1-6

In response to this:

/override metal3-bmo-e2e-test-pull test-centos-e2e-integration-release-1-6 test-ubuntu-integration-release-1-6
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/cc @kashifest @lentzi90

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@metal3-io-bot metal3-io-bot merged commit b3981c6 into metal3-io:release-0.5 Apr 25, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/backport-release-note-gen branch April 25, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants