-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 backported fixes for Makefile and release workflow #1693
🌱 backported fixes for Makefile and release workflow #1693
Conversation
Basically a cherry-pick from CAPM3 PR metal3-io#1567. Support beta and RC releases in release note generator. Move some logic from Makefile to the release note generator, and then add nice unfolding summary section to hide details in beta/rc notes. Fix previous release tag pattern detection in Makefile. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
/override metal3-bmo-e2e-test-pull test-centos-e2e-integration-release-1-6 test-ubuntu-integration-release-1-6 |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-release-1-6, test-ubuntu-integration-release-1-6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @kashifest @lentzi90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Basically a cherry-pick from CAPM3 PR #1567 originally, and manual cherry-pick of BMO PR #1636 for the release workflow / release note generator.
Support beta and RC releases in release note generator. Move some logic from Makefile to the release note generator, and then add nice unfolding summary section to hide details in beta/rc notes.
Fix previous release tag pattern detection in Makefile.