Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 improve hack/verify-release.sh script #1697

Merged
merged 1 commit into from
Apr 24, 2024
Merged

🌱 improve hack/verify-release.sh script #1697

merged 1 commit into from
Apr 24, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1691

/assign tuminoid

@tuminoid
improve hack/verify-release.sh
38bd9ef 
Few improvements from previous minor release cycle:

- add missing k8s.io/apiserver to module sync
- change artefact to artifact for more common spelling
- match container image detection from release notes to match the
  earlier change in the release tooling
- rename some of the titles to be more descriptive
- mutate go.mod files for osv-scanner so it can accurately report
  vulnerablities in golang stdlib (ie. mutate "go 1.21" directive to
  "go 1.21.9" with patch version read off from main Dockerfile
- check version of osv-scanner, <1.5.0 give weird warnings now
- make docker pull gcrane and osv-scanner images always, so it uses
  the newest versions

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot mentioned this pull request Apr 24, 2024
Merged
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 24, 2024
@tuminoid
Copy link
Member

/retitle 🌱 improve hack/verify-release.sh script

@metal3-io-bot metal3-io-bot changed the title [release-0.6] 🌱 improve hack/verify-release.sh script 🌱 improve hack/verify-release.sh script Apr 24, 2024
tuminoid
tuminoid reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-7 metal3-bmo-e2e-test-pull

kashifest
kashifest reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, metal3-centos-e2e-integration-test-release-1-7

In response to this:

/override metal3-centos-e2e-integration-test-release-1-7 metal3-bmo-e2e-test-pull

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@metal3-io-bot metal3-io-bot merged commit 9490d85 into metal3-io:release-0.6 Apr 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@tuminoid tuminoid tuminoid left review comments

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metal3-io-bot @tuminoid @kashifest