Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 PreprovisioningImage should not be created on poweroff before delete #1702

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jgato
Copy link
Contributor

@jgato jgato commented Apr 29, 2024

PreprovisioningImage not created on poweroff

What this PR does / why we need it:

There is a new state StatePoweringOffBeforeDelete
that should not create the PreprovisioningImage.

This new state comes from a previous one called
StateDeleting that was contemplated about
not creating the PreprovisioningImage.

Just added the new state to nor create the image.

Tested with the changes over release 4.14 on an OCP4.14 cluster. I dont think it should be different on higher versions. Suggestions?

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 29, 2024
@metal3-io-bot
Copy link
Contributor

Hi @jgato. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2024
@jgato jgato changed the title 🐛 PreprovisioningImage should not be created on poweroff 🐛 PreprovisioningImage should not be created on poweroff before delete Apr 29, 2024
@dtantsur
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024
PreprovisioningImage not created on poweroff

There is a new state StatePoweringOffBeforeDelete
that should not create the PreprovisioningImage.

This new state comes from a previous one called
StateDeleting that was contemplated about
not creating the PreprovisioningImage.

Just added the new state to nor create the image

Signed-off-by: Jose Gato <jgato@redhat.com>
@jgato jgato force-pushed the PreprovisioningImage-poweroff branch from dce5ce0 to d2d700e Compare April 29, 2024 11:29
@dtantsur
Copy link
Member

/approve
/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@zaneb
Copy link
Member

zaneb commented Apr 29, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@metal3-io-bot metal3-io-bot merged commit ce4b79d into metal3-io:main Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants