-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Refactoring: split update_opts.go and updateopts_test.go #1717
Conversation
/ok-to-test |
/retitle 🌱 Refactoring: split update_opts.go and updateopts_test.go |
update_opts.go contains helpers for Ironic PATCH API that are not tied to the provisioner and thus are better haused in the clients module (renamed to match the existing convention). updateopts_test.go is a mix of tests for update_opts.go and a few provision-specific functions. The former are migrated to clients as well, the latter - to the more suitable provision_test.py. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
849911e
to
6d8ab3b
Compare
/test metal3-bmo-e2e-test-pull |
2 similar comments
/test metal3-bmo-e2e-test-pull |
/test metal3-bmo-e2e-test-pull |
/lgtm |
/ok-to-test |
/cc @kashifest @honza @zaneb |
Seems reasonable to me /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
update_opts.go contains helpers for Ironic PATCH API that are not tied
to the provisioner and thus are better haused in the clients module
(renamed to match the existing convention).
updateopts_test.go is a mix of tests for update_opts.go and a few
provision-specific functions. The former are migrated to clients as
well, the latter - to the more suitable provision_test.py.
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com