Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 add OWNERS_ALIASES support #1730

Merged
merged 1 commit into from
May 17, 2024
Merged

🌱 add OWNERS_ALIASES support #1730

merged 1 commit into from
May 17, 2024

Conversation

tuminoid
Copy link
Member

OWNERS_ALIASES groups are needed for fair blunderbuss review requests, allowing approvers also to be requested and not only reviewers.

@tuminoid
add OWNERS_ALIASES support
d18d7e0 
OWNERS_ALIASES groups are needed for fair blunderbuss review requests.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot requested review from mquhuy and Rozzii May 17, 2024 10:29
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2024
@tuminoid
Copy link
Member Author

/cherry-pick release-0.6

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/cherry-pick release-0.5

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/cc @lentzi90 @kashifest

@tuminoid
Copy link
Member Author

/override metal3-bmo-e2e-test-pull

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull

In response to this:

/override metal3-bmo-e2e-test-pull

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smoshiur1237
smoshiur1237 reviewed May 17, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lentzi90
lentzi90 reviewed May 17, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@metal3-io-bot metal3-io-bot merged commit 3dc25fd into metal3-io:main May 17, 2024
12 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-owners-aliases branch May 17, 2024 12:38
@metal3-io-bot
Copy link
Contributor

@tuminoid: #1730 failed to apply on top of branch "release-0.6":

Applying: add OWNERS_ALIASES support
Using index info to reconstruct a base tree...
M	OWNERS
Falling back to patching base and 3-way merge...
Auto-merging OWNERS
CONFLICT (content): Merge conflict in OWNERS
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add OWNERS_ALIASES support
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

@tuminoid: #1730 failed to apply on top of branch "release-0.5":

Applying: add OWNERS_ALIASES support
Using index info to reconstruct a base tree...
M	OWNERS
Falling back to patching base and 3-way merge...
Auto-merging OWNERS
CONFLICT (content): Merge conflict in OWNERS
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add OWNERS_ALIASES support
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

Cherry-picks needs #1733 and #1732 to merge first, they were forgotten to cherry-pick and OWNERS is out of sync in release branches.

@tuminoid
Copy link
Member Author

/cherry-pick release-0.6

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1734

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot mentioned this pull request May 20, 2024
Merged
@tuminoid
Copy link
Member Author

/cherry-pick release-0.5

@metal3-io-bot metal3-io-bot mentioned this pull request May 20, 2024
Merged
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1735

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@mquhuy mquhuy Awaiting requested review from mquhuy

@Rozzii Rozzii Awaiting requested review from Rozzii

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @kashifest @lentzi90 @smoshiur1237