Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Upload artifacts from fixture tests #1746

Merged

Conversation

lentzi90
Copy link
Member

What this PR does / why we need it:

This improves the github workflow for fixture tests by uploading the artifacts, similar to what we already have for jenkins jobs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot requested review from tuminoid and zaneb May 23, 2024 07:33
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2024
@lentzi90 lentzi90 force-pushed the lentzi90/fixture-workflow-artifacts branch from 9129ae6 to 4c5dee5 Compare May 23, 2024 07:49
@lentzi90
Copy link
Member Author

Confirmed working. If you follow the "Details" link, you can see the URL for the artifacts at the end of the "Upload artifacts" step.
Alternatively, go to the summary page for the workflow. At the bottom there is a table for all artifacts produced by it.

This improves the github workflow for fixture tests by uploading the
artifacts, similar to what we already have for jenkins jobs.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90 lentzi90 force-pushed the lentzi90/fixture-workflow-artifacts branch from 4c5dee5 to c32de09 Compare May 23, 2024 09:09
@tuminoid
Copy link
Member

/override metal3-bmo-e2e-test-pull
This is about fixture tests.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull

In response to this:

/override metal3-bmo-e2e-test-pull
This is about fixture tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @kashifest

@metal3-io-bot metal3-io-bot requested a review from kashifest May 23, 2024 10:04
@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@metal3-io-bot metal3-io-bot merged commit c89b1b2 into metal3-io:main May 28, 2024
15 of 16 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/fixture-workflow-artifacts branch May 28, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants