-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add periodic jobs for optional tests and release branches #1765
🌱 Add periodic jobs for optional tests and release branches #1765
Conversation
098ab62
to
cbcc7a1
Compare
This adds more github workflows, namely periodic jobs for the release branches with the required e2e tests and periodic jobs for the optional e2e tests for main and release branches. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
cbcc7a1
to
4792e1b
Compare
# We need a new shell to pick up the new group. That is why we do the sudo -s -u $USER ... | ||
# Remove the pre-installed go version. We install the exact version we need. | ||
run: | | ||
sudo usermod -a -G libvirt $USER | ||
sudo rm /usr/bin/go | ||
sudo -s -u $USER bash ${{ github.workspace }}/hack/ci-e2e.sh | ||
sudo -s -u $USER --preserve-env bash ${{ github.workspace }}/hack/ci-e2e.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This was a mistake in the previous PR. The env vars were not passed through. By adding --preserve-env we make sure that the environment variables really are available in the script. The consequence is that we so far only tested redfish-virtualmedia because the BMC_PROTOCOL was never set 🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
4792e1b
to
9165d81
Compare
Test commit removed. |
/hold cancel |
/lgtm |
What this PR does / why we need it:
This adds more github workflows, namely periodic jobs for the release branches with the required e2e tests and periodic jobs for the optional e2e tests for main and release branches.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #