Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 [backport] workflow pipeline with unit tests #1773

Merged
merged 1 commit into from
Jun 7, 2024
Merged

🌱 [backport] workflow pipeline with unit tests #1773

merged 1 commit into from
Jun 7, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Jun 5, 2024

Manual backport of #1770

This adds a unit test workflow and restructures the github workflows so that we run golangci-lint and unit tests first. Only when they have succeded will the pipeline continue with e2e tests. The goal is to conserve resources and avoid running pointless jobs. The commit also removes unnecessary permissions and avoids running the jobs if the PR is a draft.

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2024
@metal3-io-bot metal3-io-bot requested review from tuminoid and zaneb June 5, 2024 10:17
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 5, 2024
@lentzi90 lentzi90 marked this pull request as ready for review June 5, 2024 10:29
@lentzi90
Copy link
Member Author

lentzi90 commented Jun 5, 2024

/hold
We need #1771 first...

@lentzi90 lentzi90 marked this pull request as draft June 5, 2024 10:34
@lentzi90 lentzi90 force-pushed the lentzi90/release-0.5-pipeline branch from fba1d95 to 1909847 Compare June 6, 2024 06:47
@lentzi90
Copy link
Member Author

lentzi90 commented Jun 6, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90 lentzi90 marked this pull request as ready for review June 6, 2024 08:17
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2024
@metal3-io-bot metal3-io-bot requested a review from elfosardo June 6, 2024 08:17
@lentzi90
Workflow pipeline with unit tests
7eebeb0 
This adds a unit test workflow and restructures the github workflows
so that we run golangci-lint and unit tests first. Only when they have
succeded will the pipeline continue with e2e tests.
The goal is to conserve resources and avoid running pointless jobs.
The commit also removes unnecessary permissions and avoids running the
jobs if the PR is a draft.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90 lentzi90 force-pushed the lentzi90/release-0.5-pipeline branch from 1909847 to 7eebeb0 Compare June 6, 2024 09:21
@lentzi90
Copy link
Member Author

lentzi90 commented Jun 6, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90
Copy link
Member Author

lentzi90 commented Jun 6, 2024

/retest

@lentzi90
Copy link
Member Author

lentzi90 commented Jun 6, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@lentzi90: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull
  • /test metal3-bmo-e2e-test-pull
  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-centos-e2e-feature-test-release-1-6
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-dev-env-integration-test-centos-release-1-6
  • /test metal3-dev-env-integration-test-ubuntu-release-1-6
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-6
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-6
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-feature-test-release-1-6
  • /test metal3-ubuntu-e2e-integration-test-release-1-6

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90
Copy link
Member Author

lentzi90 commented Jun 6, 2024

/retest

@lentzi90 lentzi90 changed the title 🌱 [backport] Workflow pipeline with unit tests 🌱 [backport] workflow pipeline with unit tests Jun 6, 2024
kashifest
kashifest reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
Sunnatillo
Sunnatillo reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90
Copy link
Member Author

lentzi90 commented Jun 7, 2024

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii June 7, 2024 05:04
@mquhuy
Copy link
Member

mquhuy commented Jun 7, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
@metal3-io-bot metal3-io-bot merged commit 3d81425 into metal3-io:release-0.5 Jun 7, 2024
25 of 27 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/release-0.5-pipeline branch June 7, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid Awaiting requested review from tuminoid

@zaneb zaneb Awaiting requested review from zaneb

@elfosardo elfosardo Awaiting requested review from elfosardo

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lentzi90 @metal3-io-bot @mquhuy @Sunnatillo @kashifest