Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix hack scripts to run locally again #1796

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

tuminoid
Copy link
Member

Fix hack scripts to run locally again. We have some Git permissions issues, formatting issues, deprecated linters, bad Go configs, custom mount points etc. Now it should be cleaner, runs on Linux and Mac equally (zsh can't handle "${@}" for example)...

@metal3-io-bot metal3-io-bot requested review from kashifest and zaneb June 28, 2024 09:29
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2024
@tuminoid tuminoid force-pushed the tuomo/fix-local-hack-scripts branch from 3217f5a to f93b1d6 Compare June 28, 2024 09:32
@tuminoid
Copy link
Member Author

/cc @kashifest @mquhuy

@metal3-io-bot metal3-io-bot requested a review from mquhuy June 28, 2024 09:36
@tuminoid tuminoid force-pushed the tuomo/fix-local-hack-scripts branch 2 times, most recently from eb06131 to 897843b Compare June 28, 2024 09:55
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/cc @honza

@metal3-io-bot metal3-io-bot requested a review from honza June 28, 2024 13:11
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@Rozzii Rozzii added this to the BMO - v0.7.0 milestone Jun 28, 2024
hack/generate.sh Outdated Show resolved Hide resolved
@tuminoid tuminoid force-pushed the tuomo/fix-local-hack-scripts branch from 897843b to 72b5a7b Compare July 1, 2024 05:12
Fix hack scripts to run locally again. We have some Git permissions
issues, formatting issues, deprecated linters, bad Go configs, custom
mount points etc. Now it should be cleaner, runs on Linux and Mac
equally (zsh can't handle "${@}" for example)...

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@dtantsur
Copy link
Member

dtantsur commented Jul 1, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@metal3-io-bot metal3-io-bot merged commit 1c1699b into metal3-io:main Jul 1, 2024
20 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-local-hack-scripts branch July 1, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done / Closed
Development

Successfully merging this pull request may close these issues.

6 participants