Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Document backporting rules for Go lang minor versions for images #1798

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

kashifest
Copy link
Member

This PR also rewrites the Backporting section a bit and puts on clear identifiers for backporting rules.

@kashifest
Copy link
Member Author

/cc @dtantsur @honza

@metal3-io-bot metal3-io-bot requested review from dtantsur and honza June 28, 2024 13:42
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2024
@kashifest
Copy link
Member Author

/cc @dtantsur @honza @zaneb

@metal3-io-bot metal3-io-bot requested a review from zaneb July 4, 2024 13:02
@kashifest
Copy link
Member Author

@dtantsur @honza @elfosardo please review this before it rots

@kashifest
Copy link
Member Author

are we going to get any eyes on this?

CONTRIBUTING.md Outdated Show resolved Hide resolved
@honza
Copy link
Member

honza commented Aug 19, 2024

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
@kashifest kashifest force-pushed the kashif/document-golang-bump branch from 518840a to 0c725fd Compare August 19, 2024 09:05
Copy link
Member

@zaneb zaneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open source communities don't provide support, but we do maintain stuff.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
This PR also rewrites the Backporting section a bit and puts on clear identifiers for backporting rules.

Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@kashifest kashifest force-pushed the kashif/document-golang-bump branch from 0c725fd to 7d675b0 Compare August 19, 2024 09:11
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@metal3-io-bot metal3-io-bot merged commit 39afcb5 into metal3-io:main Aug 19, 2024
8 checks passed
@metal3-io-bot metal3-io-bot deleted the kashif/document-golang-bump branch August 19, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants