Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add BMO 0.8 e2e #1945

Merged
merged 1 commit into from
Sep 12, 2024
Merged

🌱 Add BMO 0.8 e2e #1945

merged 1 commit into from
Sep 12, 2024

Conversation

tuminoid
Copy link
Member

Add BMO 0.8 e2e and drop BMO 0.4. Add ironic 25.0 and 26.0 to overlays.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2024
@tuminoid
Copy link
Member Author

/cc @mquhuy @kashifest

@tuminoid tuminoid force-pushed the tuomo/add-bmo-0.8-e2e branch 2 times, most recently from bdf50b6 to a2f9a61 Compare September 10, 2024 13:45
@mquhuy
Copy link
Member

mquhuy commented Sep 10, 2024

We can remove the ironic upgrade tests that runs on release-0.6 (L63-80 on ironic.yaml). Also remove ironic-deployment/overlays/e2e-release-24.0-with-inspector as it's no longer in use.

@mquhuy
Copy link
Member

mquhuy commented Sep 10, 2024

We can remove the ironic upgrade tests that runs on release-0.6 (L63-80 on ironic.yaml). Also remove ironic-deployment/overlays/e2e-release-24.0-with-inspector as it's no longer in use.

The e2e-with-inspector could be removed as well.

@tuminoid
Copy link
Member Author

We can remove the ironic upgrade tests that runs on release-0.6 (L63-80 on ironic.yaml). Also remove ironic-deployment/overlays/e2e-release-24.0-with-inspector as it's no longer in use.

The e2e-with-inspector could be removed as well.

Were still testing 24.0, so why would we remove it?

@mquhuy
Copy link
Member

mquhuy commented Sep 10, 2024

We can remove the ironic upgrade tests that runs on release-0.6 (L63-80 on ironic.yaml). Also remove ironic-deployment/overlays/e2e-release-24.0-with-inspector as it's no longer in use.

The e2e-with-inspector could be removed as well.

Were still testing 24.0, so why would we remove it?

The idea is to test ironic upgrade with BMO version fixed to the latest stable release.
If we test 24.0, then please change the BMO overlay to release-0.8 on that test.

@tuminoid
Add BMO 0.8 e2e
cd30cfc 
Add BMO 0.8 e2e and drop BMO 0.4. Add ironic 25.0 and 26.0 to
overlays.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/add-bmo-0.8-e2e branch from a2f9a61 to cd30cfc Compare September 10, 2024 14:20
@tuminoid
Copy link
Member Author

OK, got the spec meaning now, revamped them. PTAL.

@mquhuy
Copy link
Member

mquhuy commented Sep 10, 2024

/lgtm
The cleaning up can be done later then.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@tuminoid
Copy link
Member Author

/retest

@mquhuy
Copy link
Member

mquhuy commented Sep 11, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@mquhuy: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • markdownlint
  • shellcheck
  • test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

/retest

kashifest
kashifest reviewed Sep 11, 2024
View reviewed changes
test/e2e/config/fixture.yaml
@@ -3,7 +3,7 @@ images:
- name: quay.io/metal3-io/baremetal-operator:e2e
loadBehavior: tryLoad
# Save some time and network by using cached images if available
- name: quay.io/metal3-io/baremetal-operator:release-0.4
- name: quay.io/metal3-io/baremetal-operator:release-0.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from release-0.4 to release-0.8 ? Why the jump? Were we doing things wrongly before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is preloading images. We don't use 0.4 anymore, and I guess forgot to bump it. I figured 0.8 is most used, so preloading it helps the most?

test/e2e/config/ironic.yaml
@@ -5,7 +5,7 @@ images:
- name: quay.io/metal3-io/ironic:e2e
loadBehavior: tryLoad
# Save some time and network by using cached images if available
- name: quay.io/metal3-io/baremetal-operator:release-0.4
- name: quay.io/metal3-io/baremetal-operator:release-0.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@tuminoid
Copy link
Member Author

/retest

@metal3-io-bot metal3-io-bot merged commit a1cddc9 into metal3-io:main Sep 12, 2024
21 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-bmo-0.8-e2e branch September 12, 2024 07:55
@mquhuy mquhuy mentioned this pull request Sep 13, 2024
Closed
50 tasks
@mquhuy mquhuy mentioned this pull request Dec 5, 2024
Open
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@s3rj1k s3rj1k Awaiting requested review from s3rj1k

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

@mquhuy mquhuy Awaiting requested review from mquhuy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @mquhuy @metal3-io-bot @kashifest