Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Revert "use ubuntu-latest rather than hosted 4-core runner" #1980

Merged
merged 1 commit into from
Oct 3, 2024
Merged

🌱 Revert "use ubuntu-latest rather than hosted 4-core runner" #1980

merged 1 commit into from
Oct 3, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Oct 2, 2024

This reverts commit 6aa2b8e.

ubuntu-latest only has 14GB disk, while ubuntu-latest-4-cores has 140GB. Our optional e2e tests need more disk for the VM disks than ubuntu-latest can offer, hence reverting.

@tuminoid
Revert "use ubuntu-latest rather than hosted 4-core runner"
48aedd9 
This reverts commit 6aa2b8e.

ubuntu-latest only has 14GB disk, while ubuntu-latest-4-cores has 140GB.
Our optional e2e tests need more disk for the VM disks than
ubuntu-latest can offer, hence reverting.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/revert-runner-change branch from 9cdeddf to 48aedd9 Compare October 2, 2024 14:25
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Oct 2, 2024

/cc @kashifest @Rozzii

@tuminoid
Copy link
Member Author

tuminoid commented Oct 2, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@tuminoid: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
Rozzii
Rozzii reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2024
@metal3-io-bot metal3-io-bot merged commit 93c6a4b into metal3-io:main Oct 3, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/revert-runner-change branch October 3, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @kashifest @Rozzii