Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fetch Ironic node list after each e2e test #2028

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Nov 1, 2024

Fixes #1383

There will be a new file called "ironic-nodes.json" in the testcase log directory.

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2024
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2024
@mquhuy mquhuy changed the title WIP Fetch Ironic node list after each e2e test WIP 🌱 Fetch Ironic node list after each e2e test Nov 1, 2024
@mquhuy mquhuy force-pushed the mquhuy/fetch-ironic-nodes branch from 8c2b0b6 to 4b5c40c Compare November 1, 2024 08:26
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2024
@mquhuy mquhuy force-pushed the mquhuy/fetch-ironic-nodes branch 6 times, most recently from bf15dbf to 1c72ffe Compare November 1, 2024 09:12
@mquhuy
Copy link
Member Author

mquhuy commented Nov 1, 2024

/retest

@mquhuy mquhuy changed the title WIP 🌱 Fetch Ironic node list after each e2e test 🌱 Fetch Ironic node list after each e2e test Nov 1, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Nov 1, 2024

test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/fetch-ironic-nodes branch 4 times, most recently from 1b1b654 to 60234b5 Compare November 1, 2024 14:25
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2024
@mquhuy mquhuy force-pushed the mquhuy/fetch-ironic-nodes branch 2 times, most recently from a6340dd to ba75869 Compare November 1, 2024 14:31
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
/approve

test/e2e/e2e_config.go Outdated Show resolved Hide resolved
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/fetch-ironic-nodes branch from ba75869 to ad35224 Compare November 4, 2024 07:18
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@metal3-io-bot metal3-io-bot merged commit 2b1fb3d into metal3-io:main Nov 4, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/fetch-ironic-nodes branch November 4, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2e resource collection
4 participants