Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow FirmwareUpdates via Servicing with HostUpdatePolicy #2044

Merged
merged 1 commit into from
Nov 13, 2024
Merged

✨ Allow FirmwareUpdates via Servicing with HostUpdatePolicy #2044

merged 1 commit into from
Nov 13, 2024

Conversation

iurygregory
Copy link
Member

What this PR does / why we need it: This a follow-up to add support for Firmware Updates via HostUpdatePolicy, finalizing the implementation of metal3-io/metal3-docs@e260d42

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 6, 2024
@iurygregory
Copy link
Member Author

/hold we need to wait for #2041 so I can rebase this one.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2024
@iurygregory
Copy link
Member Author

/unhold

@iurygregory
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@iurygregory
Copy link
Member Author

/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 8, 2024
@rhjanders
Copy link
Member

Thank you Iury. It passes CI and addresses in-code TODOs so
/lgtm
(let me try if I have reviewer rights upstream).
If this works it would be get another pair of eyes on it, too, since I am still very new to this codebase.

@metal3-io-bot
Copy link
Contributor

@rhjanders: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Thank you Iury. It passes CI and addresses in-code TODOs so
/lgtm
(let me try if I have reviewer rights upstream).
If this works it would be get another pair of eyes on it, too, since I am still very new to this codebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhjanders
Copy link
Member

@rhjanders: adding LGTM is restricted to approvers and reviewers in OWNERS files.

well, clearly I do not :)

@tuminoid
Copy link
Member

/cc @lentzi90 @dtantsur

@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 11, 2024
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@dtantsur
Copy link
Member

/cc @zaneb

@metal3-io-bot metal3-io-bot requested a review from zaneb November 12, 2024 12:56
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@honza
Copy link
Member

honza commented Nov 12, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@iurygregory iurygregory requested a review from dtantsur November 13, 2024 01:54
lentzi90
lentzi90 reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@iurygregory
Allow Firmware Updates via Servicing with HostUpdatePolicy
d5e8308 
This commit adds the support for firmware updates using
HostUpdatePolicy.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@iurygregory
Copy link
Member Author

e2e-test (ipmi) Error: No files were found with the provided path: test/e2e/_artifacts. No artifacts will be uploaded. 🤔

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@iurygregory iurygregory changed the title ✨ Allow Firmware Updates via Servicing with HostUpdatePolicy ✨ Allow FirmwareUpdates via Servicing with HostUpdatePolicy Nov 13, 2024
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@metal3-io-bot metal3-io-bot merged commit f34c7ac into metal3-io:main Nov 13, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@dtantsur dtantsur dtantsur approved these changes

@elfosardo elfosardo Awaiting requested review from elfosardo

@honza honza Awaiting requested review from honza

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@iurygregory @rhjanders @metal3-io-bot @tuminoid @elfosardo @dtantsur @honza @zaneb @lentzi90