Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Pin ironic as workaround for failing tests #2112

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Dec 9, 2024

What this PR does / why we need it:

The live-ISO test is currently failing due to a bug in ironic. To avoid blocking main while this is sorted out, this commit pins ironic to an unaffected version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Workaround for #2110

The live-ISO test is currently failing due to a bug in ironic. To avoid
blocking main while this is sorted out, this commit pins ironic to an
unaffected version.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Virtualmedia passes.

When merged, create revert PR that doubles as verification that upstream patch is working.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
@metal3-io-bot metal3-io-bot merged commit 43bc68f into metal3-io:main Dec 9, 2024
15 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/unblock-main branch December 9, 2024 08:39
@Rozzii Rozzii mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants