Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump Golang to v1.23.4, CAPI to v1.9.0-rc.1 and, k8s.io/utils #2114

Conversation

peppi-lotta
Copy link
Member

What this PR does / why we need it: Bump Golang to v1.23.4, CAPI to v1.9.0-rc.1, controller-runtime to v0.19.3 and, k8s.io/utils

@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-v1.23.4-CAPI-to-v1.9.0-rc.1-and-more branch from 4b5811c to 6a7a5a9 Compare December 9, 2024 11:15
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR is being bumped by dependabot here #2106 so you need another rebase soon.

apis/go.mod Outdated Show resolved Hide resolved
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-v1.23.4-CAPI-to-v1.9.0-rc.1-and-more branch from 6a7a5a9 to 78b639f Compare December 9, 2024 11:18
@peppi-lotta peppi-lotta marked this pull request as draft December 9, 2024 11:24
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-v1.23.4-CAPI-to-v1.9.0-rc.1-and-more branch from 78b639f to e5c6526 Compare December 9, 2024 12:51
@peppi-lotta peppi-lotta marked this pull request as ready for review December 9, 2024 12:51
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-v1.23.4-CAPI-to-v1.9.0-rc.1-and-more branch from e5c6526 to cadd504 Compare December 9, 2024 13:05
@peppi-lotta peppi-lotta changed the title 🌱 Bump Golang to v1.23.4, CAPI to v1.9.0-rc.1, controller-runtime to v0.19.3 and, k8s.io/utils 🌱 Bump Golang to v1.23.4, CAPI to v1.9.0-rc.1 and, k8s.io/utils Dec 9, 2024
…d, CAPI to v1.9.0-rc.1

Signed-off-by: Peppi-Lotta <peppi-lotta.saari@est.tech>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/Bump-Golang-to-v1.23.4-CAPI-to-v1.9.0-rc.1-and-more branch from cadd504 to e9c5d24 Compare December 9, 2024 13:13
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@metal3-io-bot metal3-io-bot merged commit e709508 into metal3-io:main Dec 10, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/Bump-Golang-to-v1.23.4-CAPI-to-v1.9.0-rc.1-and-more branch December 10, 2024 07:22
@metal3-io-bot metal3-io-bot added this to the BMO - v0.9 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants