-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add hack/tools to bed linted and fix errors in deploy-cli #2123
Conversation
Can you also make it part of linting targets, so it does not get broken again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though you have linked the related issue in the PR message, that won't be visible in the git history as you have no explanation in the commit message.
Please add a short explanation of the issue and the solution to the commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message.
4ba5f52
to
f6bf2bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Is there any test we can trigger here that would actually make use of the deploy-cli?
/approve
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing GH workflow matrix addition.
/hold
/retitle 🐛 Add hack/tools to bed linted and fix errors in deploy-cli |
f6bf2bd
to
cf47f48
Compare
This commit fixes errors found by osv-scanner in deploy-cli [1] It also adds `hack/tools` package as a linting target, so that any failure due to dependencies changes will get detected in the future. [1] metal3-io#2121 Signed-off-by: Huy Mai <huy.mai@est.tech>
cf47f48
to
25f0c32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold |
What this PR does / why we need it:
This pr fixes errors found by osv-scanner in deploy-cli.
It also adds
hack/tools
package as a linting target, so thatany failure due to dependencies changes will get detected in the future.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2121