Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root device hints #495

Merged
merged 4 commits into from
Jun 2, 2020
Merged

Commits on May 29, 2020

  1. add root device hints to BareMetalHost

    Add a new field spec.rootDeviceHints to the API with sub-fields for
    different types of hints based on what Ironic supports today.
    
    Add a new field status.rootDeviceHints to record the values used when
    provisioning the host.
    
    Change the Provisioner API to return the new public struct with the
    more detailed device hints so that the values in the hard-coded
    profiles can be stored directly in the new status field.
    
    If the user does not provide explicit hints, use the values from the
    profile.
    
    Implements https://github.com/metal3-io/metal3-docs/blob/master/design/user-defined-root-device-hints.md
    
    Co-Authored-By: Mika Koskimaki <mika.koskimaki@est.tech>
    Co-Authored-By: Doug Hellmann <dhellmann@redhat.com>
    Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
    mikkosest and dhellmann committed May 29, 2020
    Configuration menu
    Copy the full SHA
    86ffcc8 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. update api docs for root device hints

    Add a missing reference to the hardwareProfile in the spec section so
    that we can include a deprecation warning.
    
    Add missing fields in the provisioning status section so that we can
    extend it with the root device hints field.
    
    Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
    dhellmann committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    592d826 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. make root device hint size field explicitly a minimum value

    The default for ironic is to treat the value as an exact match, but we
    want to use it as a minimum value. Rename the field and update the
    code that produces the map to send to the ironic API to always add the
    '>=' operator.
    
    Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
    dhellmann committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    a27a5dd View commit details
    Browse the repository at this point in the history
  2. use explicit operators when passing device hints to ironic

    Instead of relying on ironic's default behavior, pass explicit
    operators with each hint.
    
    Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
    dhellmann committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c2513a6 View commit details
    Browse the repository at this point in the history