Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: ⚠️ Bump to CR v0.15.0 #1002

Closed
wants to merge 5 commits into from
Closed

wip: ⚠️ Bump to CR v0.15.0 #1002

wants to merge 5 commits into from

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furkatgofurov7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adilGhaffarDev
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 26, 2023
@adilGhaffarDev adilGhaffarDev changed the title ⚠️ Bump to CR v0.15.0 wip: ⚠️ Bump to CR v0.15.0 May 26, 2023
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2023
@adilGhaffarDev adilGhaffarDev marked this pull request as draft May 26, 2023 07:54
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
@adilGhaffarDev adilGhaffarDev force-pushed the controller-runtime-uplift/adil branch from 0c3321c to d205c3c Compare May 30, 2023 13:37
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
@adilGhaffarDev adilGhaffarDev marked this pull request as ready for review May 30, 2023 14:22
@adilGhaffarDev
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@adilGhaffarDev adilGhaffarDev force-pushed the controller-runtime-uplift/adil branch 2 times, most recently from fef411c to 8fe33fa Compare May 30, 2023 14:48
@adilGhaffarDev adilGhaffarDev marked this pull request as draft May 30, 2023 14:48
@adilGhaffarDev
Copy link
Member Author

/hold until new capi release

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels May 30, 2023
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2023
@adilGhaffarDev adilGhaffarDev marked this pull request as ready for review June 22, 2023 06:35
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2023
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
golangci-lint 2fc699f link true /test golangci-lint
govet 2fc699f link true /test govet
unit 2fc699f link true /test unit
build 2fc699f link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@furkatgofurov7
Copy link
Member

@adilGhaffarDev this can be probably closed in favor of #1079 ?

@adilGhaffarDev
Copy link
Member Author

@adilGhaffarDev this can be probably closed in favor of #1079 ?

Yes we can close this one. /close

@Sunnatillo
Copy link
Member

/close

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adilGhaffarDev @metal3-io-bot @furkatgofurov7 @Sunnatillo