-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Remove m3m ownerRef from bmh #1008
base: main
Are you sure you want to change the base?
Conversation
Hi @shibaPuppy. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test-centos-e2e-integration-main |
Thanks for the PR @shibaPuppy. Maybe I missing the use case here, but regardless of the host state, we should not power down the node. Can you elaborate more on your use-case? |
@furkatgofurov7 I think it should be possible to force power off the vm to proceed with the evacuation due to memory issues. Similarly, I thought that the PM HW issue should be able to be forcibly turned off. |
that could be taken care by features, like remediation IMO rather than forcing the controller to power down the node |
In some cases, after turning off the power, the node where the OS is installed is moved to an isolated rack for inspection. I haven't used machine-health-check yet. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues close after 30d of inactivity. Reopen the issue with /close |
@metal3-io-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Rozzii |
/reopen |
@Rozzii: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As far as I can see there were no decision on this PR and @shibaPuppy is still active so I have reopened this. |
I agree that we should not be continuously forcing the power control to be on, which it appears we are currently doing because I think I'd prefer to set it inside the same block that we are setting the image, rather than relying on the state, since that could be racy. But in practice I expect this is probably ok. /cc @honza |
Looking into this a bit more deeply... I looked at our fork of the original CAPBM (from the pre-CAPM3 times), and the What really changed in CAPM3 is that 31d394f started calling |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
/hold |
Does the image block match that line? |
Yes, correct. It should do it once and leave it. I think we should stop calling We should also stop setting the owner reference, because we agreed in #1358 that that's a bug. A straight revert of 31d394f would achieve both. |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rozzii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rozzii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2e9bc9
to
83104bb
Compare
/retitle 🐛 Remove m3m ownerRef from bmh |
@shibaPuppy: Re-titling can only be requested by trusted users, like repository collaborators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Rozzii @zaneb |
metal3-io@31d394f Signed-off-by: shibaPuppy <sub951@naver.com>
Do we need to keep |
What this PR does / why we need it:
don't control bmh power state if it goes to provisioned state
provisioned was completed, we should be able to power off the node on a case-by-case.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #