Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump golang to v1.20.10 and related change #1271

Merged
merged 1 commit into from
Oct 17, 2023
Merged

🌱 Bump golang to v1.20.10 and related change #1271

merged 1 commit into from
Oct 17, 2023

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Oct 16, 2023

No description provided.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2023
@mquhuy
Copy link
Member Author

mquhuy commented Oct 16, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2023
@mquhuy
Copy link
Member Author

mquhuy commented Oct 16, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

1 similar comment
@mquhuy
Copy link
Member Author

mquhuy commented Oct 16, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

lentzi90
lentzi90 reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the change to the kubernetes version in the docs. Otherwise this looks good to me 🙂

docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
@mquhuy
Copy link
Member Author

mquhuy commented Oct 16, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

1 similar comment
@mquhuy
Copy link
Member Author

mquhuy commented Oct 16, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

lentzi90
lentzi90 reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@mquhuy
Copy link
Member Author

mquhuy commented Oct 17, 2023 •
edited
Loading

/cc @Rozzii @smoshiur1237 @adilGhaffarDev @mboukhalfa

smoshiur1237
smoshiur1237 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 2a9a253 into metal3-io:main Oct 17, 2023
15 checks passed
@metal3-io-bot metal3-io-bot deleted the uplift/go-1.20.10-mquhuy branch October 17, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @metal3-io-bot @lentzi90 @smoshiur1237