Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Stop serving v1alpha5 API Versions #1362

Merged
merged 1 commit into from
Dec 21, 2023
Merged

⚠️ Stop serving v1alpha5 API Versions #1362

merged 1 commit into from
Dec 21, 2023

Conversation

kashifest
Copy link
Member

Set v1alpha5 API types unserved and deprecated in CRDs

Part of #971

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 17, 2023
@kashifest
Copy link
Member Author

This PR follows CAPI's PR which had stopped serving v1a4 API kubernetes-sigs/cluster-api#8996. In that PR, CAPI has also dropped e2e upgrade tests from v1a4. For us, I couldn't find a simple way to drop it since they test seemed a bit convoluted to me because of parameterisation. That can be done as a followup after discussion.

@kashifest
Copy link
Member Author

/retest

@kashifest
Stop serving v1alpha5 API Versions
8672b2a 
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

lentzi90
lentzi90 reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Just noting for the future, that it would be nicer to set the deprecation notice at least one release before stop serving. I.e. we could have set deprecation in v1.5.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@tuminoid
Copy link
Member

/approve

Just noting for the future, that it would be nicer to set the deprecation notice at least one release before stop serving. I.e. we could have set deprecation in v1.5.

We have deprecation notice in 1.5.0: https://github.com/metal3-io/cluster-api-provider-metal3/releases/tag/v1.5.0

tuminoid
tuminoid reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

/cc @mboukhalfa

@lentzi90
Copy link
Member

We have deprecation notice in 1.5.0: https://github.com/metal3-io/cluster-api-provider-metal3/releases/tag/v1.5.0

Good! I was more thinking about the // +kubebuilder:deprecatedversion comments though. They would mark the API as deprecated also in Kubernetes and pop warnings when you use it.

@tuminoid
Copy link
Member

We have deprecation notice in 1.5.0: https://github.com/metal3-io/cluster-api-provider-metal3/releases/tag/v1.5.0

Good! I was more thinking about the // +kubebuilder:deprecatedversion comments though. They would mark the API as deprecated also in Kubernetes and pop warnings when you use it.

Oh yes, that would be nice in the future. The deprecation notice in release notes is not visible in the repo at all, only in the notes if you know to look, so it would also provide that information.

tuminoid
tuminoid reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@metal3-io-bot metal3-io-bot merged commit 105e803 into metal3-io:main Dec 21, 2023
16 checks passed
@metal3-io-bot metal3-io-bot deleted the deprecate/v1a4-kashif branch December 21, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kashifest @metal3-io-bot @tuminoid @lentzi90