-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Stop serving v1alpha5 API Versions #1362
Conversation
This PR follows CAPI's PR which had stopped serving v1a4 API kubernetes-sigs/cluster-api#8996. In that PR, CAPI has also dropped e2e upgrade tests from v1a4. For us, I couldn't find a simple way to drop it since they test seemed a bit convoluted to me because of parameterisation. That can be done as a followup after discussion. |
/retest |
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
bd81d81
to
8672b2a
Compare
/test-ubuntu-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Just noting for the future, that it would be nicer to set the deprecation notice at least one release before stop serving. I.e. we could have set deprecation in v1.5.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have deprecation notice in 1.5.0: https://github.com/metal3-io/cluster-api-provider-metal3/releases/tag/v1.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/cc @mboukhalfa
Good! I was more thinking about the |
Oh yes, that would be nice in the future. The deprecation notice in release notes is not visible in the repo at all, only in the notes if you know to look, so it would also provide that information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Set v1alpha5 API types unserved and deprecated in CRDs
Part of #971