-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Decoupling IPAM from CAPM3 #1442
base: main
Are you sure you want to change the base?
⚠️ Decoupling IPAM from CAPM3 #1442
Conversation
Signed-off-by: peppi-lotta <peppi-lotta.saari@est.tech>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits.
BTW, the link in PR summary links to a check in a PR, not to PR itself.
- capm3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line feed missing.
@@ -2,7 +2,7 @@ apiVersion: apps/v1 | |||
kind: Deployment | |||
metadata: | |||
name: ipam-controller-manager | |||
namespace: capm3-system | |||
namespace: ipam-provider-m3-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is one weird name. Is there reasoning behind that? I expected to see simple ipam-system
or similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Suggested ipam-metal3-system
in the IPAM PR
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These changes fix the issues produced by this PR in CAPM3