-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump golang to v1.21.7 #1496
🌱 Bump golang to v1.21.7 #1496
Conversation
Signed-off-by: muhammad adil ghaffar <muhammad.adil.ghaffar@est.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test-ubuntu-e2e-integration-release-1-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
As discussed offline, please update description to properly give background for skipping #1435 content in this bump, then feel free to unhold. |
/unhold @tuminoid is description ok? |
/unhold |
What this PR does / why we need it:
Golang 1.20 is out of support in Feb 2024. Bumping
golang
image only indockerfile
, but notgo.mod
because it will break library consumers. We are following CAPI about this. ref: kubernetes-sigs/cluster-api#9415