Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 e2e: Specify ip address pool for retreiving ip for accessing node #1528

Merged
merged 1 commit into from
Mar 19, 2024
Merged

🐛 e2e: Specify ip address pool for retreiving ip for accessing node #1528

merged 1 commit into from
Mar 19, 2024

Conversation

Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Mar 15, 2024 •
edited
Loading

This PR makes to choose ip address from baremetal pool to access node in healthcheck tests.
Node is not ssh able with provisioning ip address.
Fixes #1527

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2024
@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@Sunnatillo Sunnatillo force-pushed the fix-broken-e2e-feature-ubuntu/sunnat branch from 463c033 to f1d544f Compare March 15, 2024 15:02
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2024
@Sunnatillo Sunnatillo force-pushed the fix-broken-e2e-feature-ubuntu/sunnat branch from f1d544f to c487efb Compare March 15, 2024 15:09
@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@Sunnatillo Sunnatillo changed the title 🐛 e2e: Specify ip address pool for retreiving ip for ssh ing node 🐛 e2e: Specify ip address pool for retreiving ip for accessing node Mar 15, 2024
@Sunnatillo Sunnatillo marked this pull request as ready for review March 15, 2024 15:57
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
@Sunnatillo
Copy link
Member Author

/test-centos-e2e-feature-main

@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-feature-main

kashifest
kashifest requested changes Mar 18, 2024
View reviewed changes
test/e2e/common.go Outdated Show resolved Hide resolved
@Sunnatillo
e2e: Specify ip address pool for retreiving ip for ssh ing node
cff534b 
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
@Sunnatillo Sunnatillo force-pushed the fix-broken-e2e-feature-ubuntu/sunnat branch from c487efb to cff534b Compare March 18, 2024 08:42
@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-feature-main

1 similar comment
@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@Sunnatillo
Copy link
Member Author

networking issue

@Sunnatillo Sunnatillo closed this Mar 18, 2024
@Sunnatillo Sunnatillo reopened this Mar 18, 2024
@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-feature-main
previous one failed with networking issue

@Sunnatillo
Copy link
Member Author

/assign @kashifest @smoshiur1237 @mboukhalfa

kashifest
kashifest reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
@Sunnatillo
Copy link
Member Author

/test-ubuntu-integration-main
/est-centos-e2e-integration-main

@Sunnatillo
Copy link
Member Author

Previous fail is not related to this change.
/test-ubuntu-e2e-feature-main

@Sunnatillo
Copy link
Member Author

/test-ubuntu-e2e-feature-main
connection reset networking issue

@Sunnatillo
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@Sunnatillo
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

smoshiur1237
smoshiur1237 reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 4715900 into metal3-io:main Mar 19, 2024
20 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-broken-e2e-feature-ubuntu/sunnat branch March 19, 2024 09:06
@Sunnatillo
Copy link
Member Author

/cherry-pick release-1.6
/cherry-pick release-1.5

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: new pull request created: #1544

In response to this:

/cherry-pick release-1.6
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Mar 19, 2024
Merged
@Sunnatillo
Copy link
Member Author

/cherry-pick release-1.5

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: #1528 failed to apply on top of branch "release-1.5":

Applying: e2e: Specify ip address pool for retreiving ip for ssh ing node
Using index info to reconstruct a base tree...
M	test/e2e/common.go
A	test/e2e/healthchek.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/e2e/healthchek.go deleted in HEAD and modified in e2e: Specify ip address pool for retreiving ip for ssh ing node. Version e2e: Specify ip address pool for retreiving ip for ssh ing node of test/e2e/healthchek.go left in tree.
Auto-merging test/e2e/common.go
CONFLICT (content): Merge conflict in test/e2e/common.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 e2e: Specify ip address pool for retreiving ip for ssh ing node
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo Sunnatillo mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@kashifest kashifest kashifest approved these changes

Assignees

@mboukhalfa mboukhalfa

@kashifest kashifest

@smoshiur1237 smoshiur1237

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E feature tests are failing on heathcheck tests
5 participants
@Sunnatillo @metal3-io-bot @kashifest @smoshiur1237 @mboukhalfa