Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump cert-manager version v1.13.0 -> v1.14.0 #1559

Merged
merged 1 commit into from
Mar 26, 2024
Merged

🌱 Bump cert-manager version v1.13.0 -> v1.14.0 #1559

merged 1 commit into from
Mar 26, 2024

Conversation

lekaf974
Copy link
Contributor

What this PR does / why we need it:

Bump cert-manager version v1.13.0 -> v1.14.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1548

@lekaf974
Bump cert-manager version v1.13.0 -> v1.14.0
be7c268 
Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 22, 2024
@metal3-io-bot
Copy link
Contributor

Hi @lekaf974. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
@lekaf974 lekaf974 changed the title Bump cert-manager version v1.13.0 -> v1.14.0 🌱 Bump cert-manager version v1.13.0 -> v1.14.0 Mar 22, 2024
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2024
@kashifest
Copy link
Member

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member

/test-e2e-upgrade-main-from-release-1-6

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@kashifest
Copy link
Member

Unrelated flakes
/test-ubuntu-integration-main
/test-e2e-upgrade-main-from-release-1-6

tuminoid
tuminoid reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the contribution!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@tuminoid
Copy link
Member

/test-e2e-upgrade-main-from-release-1-6

1 similar comment
@kashifest
Copy link
Member

/test-e2e-upgrade-main-from-release-1-6

@kashifest
Copy link
Member

/test-e2e-upgrade-main

@kashifest
Copy link
Member

/override test-e2e-upgrade-main-from-release-1-6

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: test-e2e-upgrade-main-from-release-1-6

In response to this:

/override test-e2e-upgrade-main-from-release-1-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

/test-e2e-upgrade-main

@kashifest
Copy link
Member

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2024
@kashifest
Copy link
Member

/test-e2e-upgrade-main

2 similar comments
@kashifest
Copy link
Member

/test-e2e-upgrade-main

@kashifest
Copy link
Member

/test-e2e-upgrade-main

@ThoTischner
Copy link

Hey is there a reason to not update to the latest patch release 1.14.4 ?

@lekaf974
Copy link
Contributor Author

Hey is there a reason to not update to the latest patch release 1.14.4 ?

I just used the version given in the linked issue

@kashifest
Copy link
Member

/test-e2e-upgrade-main

@kashifest
Copy link
Member

/test-e2e-upgrade-main

@kashifest
Copy link
Member

/test-e2e-upgrade-main

@adilGhaffarDev why dont I see any trigger here ?

@adilGhaffarDev
Copy link
Member

/test-e2e-upgrade-main

3 similar comments
@adilGhaffarDev
Copy link
Member

/test-e2e-upgrade-main

@kashifest
Copy link
Member

/test-e2e-upgrade-main

@kashifest
Copy link
Member

/test-e2e-upgrade-main

@kashifest
Copy link
Member

/test-upgrade-main

@kashifest
Copy link
Member

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@kashifest
Copy link
Member

test-e2e-upgrade-main has succeeded here https://jenkins.nordix.org/job/metal3_capm3_main_clusterctl_upgrade_test/2/console but the status is not updated for some reason

@kashifest
Copy link
Member

test-e2e-upgrade-main has succeeded here https://jenkins.nordix.org/job/metal3_capm3_main_clusterctl_upgrade_test/2/console but the status is not updated for some reason

/override test-e2e-upgrade-main

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: test-e2e-upgrade-main

In response to this:

test-e2e-upgrade-main has succeeded here https://jenkins.nordix.org/job/metal3_capm3_main_clusterctl_upgrade_test/2/console but the status is not updated for some reason

/override test-e2e-upgrade-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit fc36054 into metal3-io:main Mar 26, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump cert-manager
6 participants
@lekaf974 @metal3-io-bot @tuminoid @kashifest @ThoTischner @adilGhaffarDev