-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Use Logf and AnnotateBmh functions from BMO E2E #1606
base: main
Are you sure you want to change the base?
🌱 Use Logf and AnnotateBmh functions from BMO E2E #1606
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
38ecf24
to
a24969d
Compare
/retest |
/test ? |
/test ? |
@mquhuy: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mboukhalfa: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a24969d
to
65efff0
Compare
Signed-off-by: Huy Mai <huy.mai@est.tech>
65efff0
to
4cfcd3f
Compare
@mquhuy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
func Logf(format string, a ...interface{}) { | ||
fmt.Fprintf(GinkgoWriter, "INFO: "+format+"\n", a...) | ||
} | ||
|
||
func LogFromFile(logFile string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about using BMO e2e Logf
. AnnotateBmh
makes sense but I think it's better to keep Logf
here. This is something that can be different in BMO and CAPM3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that makes sense, but could you elaborate on what could be the differences? This function is greatly basic, I don't see much space for diversion.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a continuation of metal3-io/baremetal-operator#1681. Should be edited and merged after the before-mentioned PR is merged.
/hold