-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add fake apiserver #1610
base: main
Are you sure you want to change the base?
✨ Add fake apiserver #1610
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e9a7158
to
d4b4b60
Compare
d4b4b60
to
6a24a8f
Compare
6a24a8f
to
a1e125f
Compare
/cc @lentzi90 @kashifest @Rozzii @tuminoid @adilGhaffarDev |
There is unrelated broken link failure, need to address that in another PR preferably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits for starters.
02cc265
to
2ee5877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dockerfile is broken now.
4b229a6
to
2a3401d
Compare
``` | ||
|
||
```shell | ||
curl <pod_ip>:<port>/register?resource=<namespace>/<cluster_name>&caKey=<caKeyEncoded>&caCert=<caCertEncoded>&etcdKey=<etcdKeyEncoded>&etcdCert=<etcdCertEncoded>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example with everything written out would be useful here
Port int | ||
} | ||
|
||
func register(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a docstring here describing what this function does? Include the URL parameters
|
||
} | ||
|
||
func updateNode(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description would be nice here also
|
||
## How to use | ||
|
||
After building the container image and deploy it to a kubernetes cluster, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minimal example of how to do this would be very helpful.
docker build ...
kind load image ... # or docker push
kubectl create deploy ...
kubectl create service ... # or get IP of pod
kubectl port-forward ...
2a3401d
to
009fe7c
Compare
3a90e95
to
d3d61a0
Compare
Signed-off-by: Huy Mai <huy.mai@est.tech>
d3d61a0
to
267f75e
Compare
Fake API server is a tool running inside a kubernetes cluster, and "generates" in-memory api server endpoints. These endpoints can be used, for e.g., to represent the clusters created by CAPM3 using fake hardware so that CAPI confirms that the cluster was provisioned successfully.