Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump sigs.k8s.io/controller-runtime from 0.16.5 to 0.16.6 in /test #1799

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 18, 2024

Bumps sigs.k8s.io/controller-runtime from 0.16.5 to 0.16.6.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.16.6

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.16.5...v0.16.6

Commits
  • cc6cba0 Merge pull request #2816 from k8s-infra-cherrypick-robot/cherry-pick-2813-to-...
  • 0bb3250 Reintroduce AddMetricsExtraHandler on manager
  • 24c2359 Merge pull request #2814 from vincepri/k8s-1289
  • 4964929 [release-0.16] Update to Kubernetes v0.28.9
  • 38e7e99 Merge pull request #2775 from k8s-infra-cherrypick-robot/cherry-pick-2771-to-...
  • c9bfc87 ✨ client: Add client-wide fieldManager
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 18, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adilghaffardev for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2024
@metal3-io-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 18, 2024
@kashifest
Copy link
Member

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
@kashifest
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/test/release-1.6/sigs.k8s.io/controller-runtime-0.16.6 branch from 006796e to abbed5e Compare June 18, 2024 14:22
@kashifest
Copy link
Member

title says its bumping to v0.16.6 but why on earth in the code its bumping to v0.17.x

@kashifest
Copy link
Member

@dependabot show sigs.k8s.io/controller-runtime ignore conditions

Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 18, 2024

No ignore conditions found for the dependency sigs.k8s.io/controller-runtime

@kashifest
Copy link
Member

Issue opened in depedabot dependabot/dependabot-core#10037 lets see

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.16.5 to 0.16.6.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.16.5...v0.16.6)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/test/release-1.6/sigs.k8s.io/controller-runtime-0.16.6 branch from abbed5e to d231964 Compare June 20, 2024 13:47
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2024
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rozzii
Copy link
Member

Rozzii commented Jun 28, 2024

I won't add a milestone to this because this might not even get merged .

@kashifest
Copy link
Member

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 12, 2024

The dependabot.yml entry that created this PR has been deleted so this PR can't be recreated. Please close the PR so Dependabot can create a new one with the current dependabot.yml.

@kashifest
Copy link
Member

@dependabot close

@dependabot dependabot bot closed this Aug 12, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/test/release-1.6/sigs.k8s.io/controller-runtime-0.16.6 branch August 12, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. go Pull requests that update Go code needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants