Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixing bmo and ironic version for clusterctl tests #1842

Merged

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
Manual backport of this PR: #1596 on 1.6 branch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1832

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 11, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-ironic-bmo-upgrade-1.6/adil branch 3 times, most recently from bf5986d to 0071260 Compare July 11, 2024 12:53
@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 11, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-ironic-bmo-upgrade-1.6/adil branch 2 times, most recently from 3f1e5b5 to 260fa2c Compare July 11, 2024 13:14
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-ironic-bmo-upgrade-1.6/adil branch 2 times, most recently from b3d2589 to 949cb99 Compare July 11, 2024 13:34
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-release-1-6

@adilGhaffarDev adilGhaffarDev force-pushed the fix-ironic-bmo-upgrade-1.6/adil branch from 949cb99 to df95e55 Compare July 12, 2024 07:46
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-release-1-6

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@adilGhaffarDev
Copy link
Member Author

@mboukhalfa, please check

@adilGhaffarDev adilGhaffarDev force-pushed the fix-ironic-bmo-upgrade-1.6/adil branch from df95e55 to 08a2832 Compare July 12, 2024 12:26
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
@adilGhaffarDev adilGhaffarDev force-pushed the fix-ironic-bmo-upgrade-1.6/adil branch from 08a2832 to 57861f4 Compare July 12, 2024 12:29
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-release-1-6

@Rozzii
Copy link
Member

Rozzii commented Jul 15, 2024

/test metal3-ubuntu-e2e-integration-test-release-1-6
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@metal3-io-bot metal3-io-bot merged commit 812549d into metal3-io:release-1.6 Jul 15, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-ironic-bmo-upgrade-1.6/adil branch July 15, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants