-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Bump go 1.19 , CAPI to v1.3.0-beta.1, Ginkgo/v2 and bump related go modules #774
Conversation
/test-ubuntu-integration-main |
/test all |
3 similar comments
/test all |
/test all |
/test all |
/test-ubuntu-e2e-parallel-main |
/test-ubuntu-e2e-parallel-main |
1 similar comment
/test-ubuntu-e2e-parallel-main |
This is testing CAPM3 itself but we could /should test it including the IPAM changes in metal3-io/ip-address-manager#164 as well |
/test-ubuntu-e2e-parallel-main |
/test-ubuntu-e2e-parallel-main |
/test-features-ubuntu |
d36edde
to
1aa4584
Compare
/test-ubuntu-e2e-parallel-main |
1aa4584
to
dde5ff8
Compare
/test-ubuntu-e2e-parallel-main |
/test-ubuntu-e2e-main |
4 similar comments
/test-ubuntu-e2e-main |
/test-ubuntu-e2e-main |
/test-ubuntu-e2e-main |
/test-ubuntu-e2e-main |
15a9daa
to
a732b33
Compare
/test-ubuntu-e2e-main |
3402658
to
c502609
Compare
/test-ubuntu-e2e-main |
ad9315f
to
55c1982
Compare
83898ff
to
ee4765e
Compare
ee4765e
to
c1979b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
You can also use |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ginkgo is just for the test code. Generally changes to test code is not considered when deciding if the change is breaking or not, since it will not impact end users. |
I would generally agree, to label it as a breaking change (considering CAPI PR labelling kubernetes-sigs/cluster-api#6906). Also, CAPI uplift is considered a breaking change and once this is merged, we would have a minor release from the provider, so +1 for |
Agreed, the CAPI minor version uplift makes sense as breaking change! |
/test gomod |
metal3-io/metal3-dev-env#1097 is merged, triggering the main test /test-ubuntu-integration-main |
Unrelated CI issue /test-ubuntu-integration-main |
/test-ubuntu-integration-main |
3 similar comments
/test-ubuntu-integration-main |
/test-ubuntu-integration-main |
/test-ubuntu-integration-main |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7, smoshiur1237 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #773
Also adds a fix for kustomization for darwin.