Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Bump go 1.19 , CAPI to v1.3.0-beta.1, Ginkgo/v2 and bump related go modules #774

Merged
merged 3 commits into from
Nov 14, 2022
Merged

⚠️ Bump go 1.19 , CAPI to v1.3.0-beta.1, Ginkgo/v2 and bump related go modules #774

merged 3 commits into from
Nov 14, 2022

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented Nov 4, 2022 •
edited by furkatgofurov7

Fixes: #773
Also adds a fix for kustomization for darwin.

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 4, 2022
@kashifest kashifest mentioned this pull request Nov 4, 2022
Closed
@mquhuy
Copy link
Member

mquhuy commented Nov 4, 2022

/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/test all

3 similar comments
@kashifest
Copy link
Member Author

/test all

@furkatgofurov7
Copy link
Member

/test all

@kashifest
Copy link
Member Author

/test all

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-parallel-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-parallel-main

1 similar comment
@kashifest
Copy link
Member Author

/test-ubuntu-e2e-parallel-main

@furkatgofurov7
Copy link
Member

This is testing CAPM3 itself but we could /should test it including the IPAM changes in metal3-io/ip-address-manager#164 as well

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-parallel-main

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-parallel-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/test-features-ubuntu

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-parallel-main

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-parallel-main

@furkatgofurov7
Copy link
Member

/test-ubuntu-e2e-main

4 similar comments
@furkatgofurov7
Copy link
Member

/test-ubuntu-e2e-main

@furkatgofurov7
Copy link
Member

/test-ubuntu-e2e-main

@furkatgofurov7
Copy link
Member

/test-ubuntu-e2e-main

@furkatgofurov7
Copy link
Member

/test-ubuntu-e2e-main

@furkatgofurov7
Copy link
Member

/test-ubuntu-e2e-main

@furkatgofurov7 furkatgofurov7 force-pushed the uplift/go-1.19 branch 2 times, most recently from 3402658 to c502609 Compare November 8, 2022 16:36
@furkatgofurov7
Copy link
Member

/test-ubuntu-e2e-main

@furkatgofurov7 furkatgofurov7 force-pushed the uplift/go-1.19 branch 2 times, most recently from ad9315f to 55c1982 Compare November 8, 2022 22:04
@mboukhalfa mboukhalfa mentioned this pull request Nov 14, 2022
Closed
lentzi90
lentzi90 reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@kashifest
Copy link
Member Author

/retest

@mboukhalfa
Copy link
Member

You can also use ⚠️ as ginkgo uplift is breaking changes

@mboukhalfa
Copy link
Member

/lgtm

smoshiur1237
smoshiur1237 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lentzi90
Copy link
Member

You can also use warning as ginkgo uplift is breaking changes

Ginkgo is just for the test code. Generally changes to test code is not considered when deciding if the change is breaking or not, since it will not impact end users.

@furkatgofurov7
Copy link
Member

You can also use warning as ginkgo uplift is breaking changes

Ginkgo is just for the test code. Generally changes to test code is not considered when deciding if the change is breaking or not, since it will not impact end users.

I would generally agree, to label it as a breaking change (considering CAPI PR labelling kubernetes-sigs/cluster-api#6906). Also, CAPI uplift is considered a breaking change and once this is merged, we would have a minor release from the provider, so +1 for ⚠️ in PR title here and in metal3-io/ip-address-manager#164

@furkatgofurov7 furkatgofurov7 changed the title 🌱 Bump go 1.19 , CAPI to v1.3.0-beta.1, Ginkgo/v2 and bump related go modules ⚠️ Bump go 1.19 , CAPI to v1.3.0-beta.1, Ginkgo/v2 and bump related go modules Nov 14, 2022
@lentzi90
Copy link
Member

Agreed, the CAPI minor version uplift makes sense as breaking change!

@furkatgofurov7
Copy link
Member

/test gomod

@furkatgofurov7 furkatgofurov7 mentioned this pull request Nov 14, 2022
Merged
@furkatgofurov7
Copy link
Member

metal3-io/metal3-dev-env#1097 is merged, triggering the main test

/test-ubuntu-integration-main

@furkatgofurov7
Copy link
Member

Unrelated CI issue

/test-ubuntu-integration-main

@furkatgofurov7
Copy link
Member

/test-ubuntu-integration-main

3 similar comments
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/test-ubuntu-integration-main

@furkatgofurov7 furkatgofurov7 mentioned this pull request Nov 14, 2022
Closed
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@metal3-io-bot metal3-io-bot merged commit e735768 into metal3-io:main Nov 14, 2022
@furkatgofurov7 furkatgofurov7 mentioned this pull request Dec 6, 2022
Closed
@kashifest kashifest deleted the uplift/go-1.19 branch December 9, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mboukhalfa mboukhalfa mboukhalfa left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt and test CAPI v1.3.0-beta.0 release
7 participants
@kashifest @mquhuy @furkatgofurov7 @mboukhalfa @lentzi90 @metal3-io-bot @smoshiur1237