-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Support for FailureDomains #793
base: main
Are you sure you want to change the base?
Conversation
Hi @f1tzpatrick. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a1c0cfa
to
c68214e
Compare
c68214e
to
326d4ae
Compare
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues close after 30d of inactivity. Reopen the issue with /close |
@metal3-io-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
5 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
/remove-lifecycle stale |
I am very sorry folks, this somehow fallen through the cracks and I've forgot to review it, I am not an expert on the topic so @lentzi90 @kashifest please help us. |
/retest |
1760526
to
7c21ccd
Compare
Sorry, I'll get these passing locally before I push again ^^ @lentzi90 do you know if the unit test in the github action is the same as
Even with Any thoughts? |
Odd! The unit test is running hack/unit.sh which should be the same as |
@lentzi90 sorry to keep you waiting, I want to try this again on my linux box at home. I'll try to get to it this evening! |
No worries! It should work pretty well also in GitHub Codespaces if you want to try it that way 🙂 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues close after 30d of inactivity. Reopen the issue with /close |
@metal3-io-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-lifecycle stale |
@Rozzii: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sf1tzp: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This change adds FailureDomain fields to M3Cluster and M3Machine types, and adds logic to the M3Machine manager code for selecting a host based on a specified FailureDomain.
Related-To: #402
Signed-off-by: Steven Fitzpatrick steven@fitz.gg