Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bumping CAPI to 1.4.7 #333

Merged
merged 1 commit into from
Sep 27, 2023
Merged

🌱 Bumping CAPI to 1.4.7 #333

merged 1 commit into from
Sep 27, 2023

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Sep 27, 2023 •
edited

What this PR does / why we need it:

  • Bump CAPI to v1.4.7
  • Bump Cert-manager to v1.13.0
  • Bump GO to 1.20.8

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2023
@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-4

kashifest
kashifest reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
smoshiur1237
smoshiur1237 previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member

You're trying to bump Go in other PRs, why are we not bumping it here as well? 1.19.13 is the latest, Dockerfile has 1.19.9?

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@adilGhaffarDev
Copy link
Member Author

You're trying to bump Go in other PRs, why are we not bumping it here as well? 1.19.13 is the latest, Dockerfile has 1.19.9?

/hold

Should we move to 1.20 as CAPI is doing? ref: kubernetes-sigs/cluster-api@6b7d2b2

@kashifest
Copy link
Member

Should we move to 1.20 as CAPI is doing? ref: kubernetes-sigs/cluster-api@6b7d2b2

+1

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2023
@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-4

@kashifest
Copy link
Member

Should we move to 1.20 as CAPI is doing? ref: kubernetes-sigs/cluster-api@6b7d2b2

go.mod stays at go1.19?

@adilGhaffarDev
Copy link
Member Author

go.mod stays at go1.19?

Yes, here is the explanation regarding that: kubernetes-sigs/cluster-api#9415

tuminoid
tuminoid reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 27, 2023
@metal3-io-bot metal3-io-bot merged commit fc0b5bf into metal3-io:release-1.4 Sep 27, 2023
11 checks passed
@Sunnatillo Sunnatillo deleted the bump-capi-1.4.7/adil branch March 4, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adilGhaffarDev @metal3-io-bot @tuminoid @kashifest @smoshiur1237