-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Uplift controller runtime, controller-tools and cluster-api #56
✨ Uplift controller runtime, controller-tools and cluster-api #56
Conversation
/test-integration |
/assign @fmuyassarov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-centos-integration |
/test-centos-integration |
/test-v1a4-integration |
v1a4 would fail on this @fmuyassarov |
Ops, sorry Kashif. I completely forgot about the API type here. |
eda4fe0
to
e6c6cf9
Compare
/test-centos-integration |
No worries. Re-ran v1a5 tests again. Lets see. |
LGTM lets wait for the tests to pass |
e6c6cf9
to
01ab1e1
Compare
/test-centos-integration |
/test-integration |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmuyassarov, namnx228, smoshiur1237 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this PR we,
The changes are influenced by: kubernetes-sigs/cluster-api#5249