Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix release-notes in Makefile #786

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Dec 12, 2024

What this PR does / why we need it: Fix the path release binary is created in. Add more logging and documentation to reduce user error when using release-notes action from Makefile.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 12, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-release-notes branch 2 times, most recently from 5e0d18b to 84a562a Compare December 12, 2024 14:16
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-release-notes branch 2 times, most recently from b0eed9f to aedc6c5 Compare December 12, 2024 14:24
@mquhuy
Copy link
Member

mquhuy commented Dec 12, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@tuminoid
Copy link
Member

I'll take a look tomorrow

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-release-notes branch from aedc6c5 to 16d228a Compare December 13, 2024 07:02
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-release-notes branch from 16d228a to fcd23cd Compare December 13, 2024 07:23
docs/releasing.md Outdated Show resolved Hide resolved
hack/tools/release/notes.go Outdated Show resolved Hide resolved
Signed-off-by: Peppi-Lotta <peppi-lotta.saari@est.tech>
@mquhuy mquhuy force-pushed the peppi-lotta/fix-release-notes branch from fcd23cd to 7be412a Compare December 20, 2024 11:53
@mquhuy mquhuy requested a review from tuminoid December 20, 2024 11:54
@mquhuy
Copy link
Member

mquhuy commented Dec 20, 2024

/cc @adilGhaffarDev @kashifest

@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Manually tested, it works as expected.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@metal3-io-bot metal3-io-bot merged commit 5fdd288 into metal3-io:main Dec 20, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/fix-release-notes branch December 20, 2024 11:57
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.10 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants