Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 add OpenSSF Scorecard badge to README #465

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

tuminoid
Copy link
Member

Add OpenSSF Scorecard badge to README. It is checked by the CLOmonitor and lowers our score by not having it. We have worked to improve the scores, so we can display the score as well.

Add OpenSSF Scorecard badge to README. It is checked by the CLOmonitor
and lowers our score by not having it. We have worked to improve the
scores, so we can display the score as well.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 21, 2023
@tuminoid
Copy link
Member Author

Scorecard is not generated for ironic-image by openssf for some reason, but it is also a code-lite repo in CLO, so it is NOT monitored for this repo.

/hold
until I've checked why the scoring is not done for this.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
@tuminoid
Copy link
Member Author

Adding ironic-image to the OpenSSF Scorecard project list, so it can display this badge: ossf/scorecard#3783

@tuminoid
Copy link
Member Author

Adding ironic-image to the OpenSSF Scorecard project list, so it can display this badge: ossf/scorecard#3783

Merged. The badge will be available sometime next week as the run cycle is one week and it is unknown which weekday will do our repos.

@tuminoid
Copy link
Member Author

/unhold
The scorecard badge is now valid as project is included in securityscorecard.dev scans.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@tuminoid
Copy link
Member Author

/override test-centos-integration-main test-ubuntu-integration-main
Its readme change.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-integration-main test-ubuntu-integration-main
Its readme change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/cc @Rozzii @lentzi90
/assign @elfosardo @dtantsur

@tuminoid
Copy link
Member Author

/retitle 📖 add OpenSSF Scorecard badge to README

@metal3-io-bot metal3-io-bot changed the title 🌱 add OpenSSF Scorecard badge to README 📖 add OpenSSF Scorecard badge to README Jan 22, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@metal3-io-bot metal3-io-bot merged commit e7c1604 into metal3-io:main Jan 22, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-openssf-badge branch January 22, 2024 09:24
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Mar 28, 2024
METAL-804: Bump ironic hash to include recent fixes and features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants