Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fix syntax in build images github workflow #554

Merged
merged 1 commit into from
Sep 5, 2024
Merged

🌱 Fix syntax in build images github workflow #554

merged 1 commit into from
Sep 5, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #539

/assign tuminoid

@NymanRobin
Fix syntax in build images github workflow
ee41101 
The syntax error in build images workflow caused
all jobs to fail.

Signed-off-by: NymanRobin <robin.nyman@est.tech>
@metal3-io-bot metal3-io-bot mentioned this pull request Sep 5, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2024
tuminoid
tuminoid reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @dtantsur

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@dtantsur
Copy link
Member

dtantsur commented Sep 5, 2024

/override metal3-centos-e2e-integration-test-release-1-7 metal3-ubuntu-e2e-integration-test-release-1-7
/approve

@metal3-io-bot
Copy link
Contributor Author

@dtantsur: Overrode contexts on behalf of dtantsur: metal3-centos-e2e-integration-test-release-1-7, metal3-ubuntu-e2e-integration-test-release-1-7

In response to this:

/override metal3-centos-e2e-integration-test-release-1-7 metal3-ubuntu-e2e-integration-test-release-1-7
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@metal3-io-bot metal3-io-bot merged commit ad543b4 into metal3-io:release-24.1 Sep 5, 2024
7 checks passed
@tuminoid tuminoid changed the title [release-24.1] 🌱 Fix syntax in build images github workflow 🌱 Fix syntax in build images github workflow Sep 5, 2024
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Oct 8, 2024
@openshift-merge-bot
Merge pull request metal3-io#554 from iurygregory/OCPBUGS-38512
ae5def3 
[4.15] OCPBUGS-38512: set min version for python3-webob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metal3-io-bot @dtantsur @tuminoid @NymanRobin