Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static test scripts #14

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add static test scripts #14

merged 1 commit into from
Mar 28, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Mar 25, 2024 •
edited
Loading

In order to prepare the repository for CI integration

This commit:

  • Adds a subset of the static analysis and formatting tools.
  • Modifies the root Makefile to allow running gomod.sh
  • aligns static test container wrapper scripts

I will align the code and the docs in multiple PRs to not create xK line PRs.

@Rozzii Rozzii requested a review from dtantsur March 25, 2024 16:48
@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 25, 2024
@tuminoid
Copy link
Member

I will align the code and the docs in multiple PRs to not create xK line PRs.

Is there a lot of issues that would fail a test? Otherwise I'd suggest enabling Prow first, so each PR could be tested.

@Rozzii Rozzii mentioned this pull request Mar 26, 2024
Merged
dtantsur
dtantsur reviewed Mar 26, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
dtantsur
dtantsur reviewed Mar 26, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
dtantsur
dtantsur reviewed Mar 26, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
dtantsur
dtantsur reviewed Mar 26, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
dtantsur
dtantsur reviewed Mar 26, 2024
View reviewed changes
test/go.mod Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
tuminoid
tuminoid reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

Dockerfile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
hack/gomod.sh Outdated Show resolved Hide resolved
elfosardo
elfosardo reviewed Mar 26, 2024
View reviewed changes
test/go.mod Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 28, 2024
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@Rozzii Rozzii force-pushed the add_static branch 2 times, most recently from 968126f to eec2613 Compare March 28, 2024 10:25
tuminoid
tuminoid requested changes Mar 28, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Rozzii Rozzii force-pushed the add_static branch 2 times, most recently from d28c946 to bee96ec Compare March 28, 2024 11:13
tuminoid
tuminoid reviewed Mar 28, 2024
View reviewed changes
hack/ensure-go.sh Outdated Show resolved Hide resolved
hack/gomod.sh Outdated Show resolved Hide resolved
tuminoid
tuminoid previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rozzii
Add static test scripts
0c90276 
In order to prepare the repository for CI integration

This commit:
- Adds a subset of the static analysis and formatting tools.
- Modifies the root Makefile to allow running gomod.sh
- aligns static test container wrapper scripts

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
@Rozzii
Copy link
Member Author

Rozzii commented Mar 28, 2024

/retest

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Mar 28, 2024

/override markdownlint
markdownlint fixes are in a separate PR let's ignore this.

@metal3-io-bot
Copy link
Contributor

@Rozzii: Overrode contexts on behalf of Rozzii: markdownlint

In response to this:

/override markdownlint
markdownlint fixes are in a separate PR let's ignore this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@metal3-io-bot metal3-io-bot merged commit 51126a5 into metal3-io:main Mar 28, 2024
8 checks passed
@tuminoid tuminoid mentioned this pull request Mar 28, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rozzii @tuminoid @elfosardo @metal3-io-bot @dtantsur