-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ allow Ironic to set nodeSelector #33
Conversation
Hi @matthewei. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
// Selector which must match a node's labels for the vmi to be scheduled on that node. | ||
// More info: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/ | ||
// +optional | ||
NodeSelector map[string]string `json:"nodeSelector,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how this will work with the future distributed architecture... I guess it depends on how this architecture looks like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact that the native kubernetes daemonset controller
also support to config nodeSelector
.
/ok-to-test |
/retitle ✨ allow Ironic to set nodeSelector Testing something that needs title edit. |
I would like to add the |
I want to solve this function request #31 |
Could you please sign off DCO? E.g. |
yes, will do it. |
https://github.com/metal3-io/ironic-standalone-operator/pull/33/checks?check_run_id=24228940700
Your signed-off-by doesn't match your git committer. |
Signed-off-by: shenwei <shenwei@cmss.chinamobile.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sometime we want to config Ironic to be set up in a known node .