Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ allow Ironic to set nodeSelector #33

Merged
merged 1 commit into from
Apr 29, 2024
Merged

✨ allow Ironic to set nodeSelector #33

merged 1 commit into from
Apr 29, 2024

Conversation

matthewei
Copy link

sometime we want to config Ironic to be set up in a known node .

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 22, 2024
@metal3-io-bot
Copy link
Contributor

Hi @matthewei. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 22, 2024
dtantsur
dtantsur reviewed Apr 22, 2024
View reviewed changes
api/v1alpha1/ironic_types.go
// Selector which must match a node's labels for the vmi to be scheduled on that node.
// More info: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/
// +optional
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this will work with the future distributed architecture... I guess it depends on how this architecture looks like.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact that the native kubernetes daemonset controller also support to config nodeSelector.

@dtantsur
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2024
@tuminoid
Copy link
Member

/retitle ✨ allow Ironic to set nodeSelector

Testing something that needs title edit.

@metal3-io-bot metal3-io-bot changed the title allow Ironic to set nodeSelector ✨ allow Ironic to set nodeSelector Apr 22, 2024
@matthewei
Copy link
Author

/retitle ✨ allow Ironic to set nodeSelector

Testing something that needs title edit.

I would like to add the e2e. But if we want to realize it. we should create at lease two nodes in a Cluster. But in this project I don't find it.

@matthewei
Copy link
Author

matthewei commented Apr 23, 2024 •
edited

I want to solve this function request #31

@dtantsur
Copy link
Member

Could you please sign off DCO? E.g. git command -s --amend followed by git push -f?

@matthewei
Copy link
Author

Could you please sign off DCO? E.g. git command -s --amend followed by git push -f?

yes, will do it.

@matthewei
Copy link
Author

matthewei commented Apr 25, 2024 •
edited

Could you please sign off DCO? E.g. git command -s --amend followed by git push -f?

yes, will do it.

Hi , How can I sign off DOC? I checked the commit info and have add it.

image

@tuminoid
Copy link
Member

https://github.com/metal3-io/ironic-standalone-operator/pull/33/checks?check_run_id=24228940700

Commit sha: [cd3d523](https://github.com/metal3-io/ironic-standalone-operator/pull/33/commits/cd3d523426a6ee85efda5f1e48f73f3370172982), Author: shenwei, Committer: shenwei; Expected "shenwei [shenwei@cmss.chinamobile.com](mailto:shenwei@cmss.chinamobile.com)", but got "Matthew Shen [shenwei_yewu@cmss.chinamobile.com](mailto:shenwei_yewu@cmss.chinamobile.com)"

Your signed-off-by doesn't match your git committer.

allow Ironic to set nodeSelector
c8558e9 
Signed-off-by: shenwei <shenwei@cmss.chinamobile.com>
@matthewei matthewei requested a review from dtantsur April 26, 2024 00:10
@dtantsur
Copy link
Member

/approve
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@metal3-io-bot metal3-io-bot merged commit 3c87152 into metal3-io:main Apr 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewei @metal3-io-bot @dtantsur @tuminoid