Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 bump golang to 1.21.10 and some deps #38

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

tuminoid
Copy link
Member

Bump golang to 1.21.10 and x/net to v0.23.0, x/crypto to v0.17.0 and google.golang.org/protobuf to v1.33.0.

test/go.mod is bumped from 1.21.6 to 1.21.9. .9 is needed for the stdlib vulnerability fixes, and some feature is requiring at least .6 to be mentioned, so it cannot be set to just "go 1.21" as we usually have.

https://osv.dev/GHSA-4v7x-pqxf-cx7m
https://osv.dev/GO-2024-2687
https://osv.dev/GHSA-45x7-px36-x8w8
https://osv.dev/GHSA-8r3f-844c-mc37

Bump golang to 1.21.10 and x/net to v0.23.0, x/crypto to v0.17.0 and
google.golang.org/protobuf to v1.33.0.

test/go.mod is bumped from 1.21.6 to 1.21.9. .9 is needed for the
stdlib vulnerability fixes, and some feature is requiring at least .6
to be mentioned, so it cannot be set to just "go 1.21" as we usually
have.

https://osv.dev/GHSA-4v7x-pqxf-cx7m
https://osv.dev/GO-2024-2687
https://osv.dev/GHSA-45x7-px36-x8w8
https://osv.dev/GHSA-8r3f-844c-mc37

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2024
@tuminoid
Copy link
Member Author

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii May 20, 2024 09:03
@Rozzii
Copy link
Member

Rozzii commented May 21, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@tuminoid
Copy link
Member Author

/hold
This is ready and good to merge, but I'll hold it as I need a repo that has open vulns for testing osv-scanner for a day or two.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@tuminoid
Copy link
Member Author

/unhold

Tests done good to merge.
/cc @dtantsur

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2024
@dtantsur
Copy link
Member

dtantsur commented Jun 5, 2024

/approve
/lgtm

Thanks! Feel free to ping me on slack if I miss notifications about new PRs.

@dtantsur dtantsur merged commit 938d10e into metal3-io:main Jun 5, 2024
7 of 8 checks passed
@tuminoid tuminoid deleted the tuomo/bump-golang branch June 10, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants