Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OWNERS_ALIASES support #1403

Merged
merged 1 commit into from
May 17, 2024
Merged

add OWNERS_ALIASES support #1403

merged 1 commit into from
May 17, 2024

Conversation

tuminoid
Copy link
Member

OWNERS_ALIASES groups are needed for fair blunderbuss review requests.

@tuminoid
add OWNERS_ALIASES support
ebdba4f 
OWNERS_ALIASES groups are needed for fair blunderbuss review requests.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2024
@tuminoid
Copy link
Member Author

/override metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-7, metal3-dev-env-integration-test-ubuntu-main

In response to this:

/override metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/cc @kashifest @lentzi90

smoshiur1237
smoshiur1237 approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
lentzi90
lentzi90 reviewed May 17, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lentzi90,smoshiur1237]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lentzi90
Copy link
Member

Changing to lgtm...
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@metal3-io-bot metal3-io-bot merged commit c756ad4 into metal3-io:main May 17, 2024
3 of 4 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-owners-aliases branch May 17, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

@dtantsur dtantsur Awaiting requested review from dtantsur

@elfosardo elfosardo Awaiting requested review from elfosardo

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @lentzi90 @smoshiur1237