-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed broken link reference to CRs #447
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @chibuikeIg. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR! Please fix the DCO (sign-off the commit) and repush. /ok-to-test PTAL if the linking the last version of the CRS is the right link to replace the dead link, or was the content actually migrated elsewhere. |
Signed-off-by: chibuikeIg <paulchibuikeigweze@gmail.com>
Update version support tables with information abotu ironic-image tags and releases. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech> Signed-off-by: chibuikeIg <paulchibuikeigweze@gmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com> Signed-off-by: chibuikeIg <paulchibuikeigweze@gmail.com>
I think it was migrated under the |
I think this whole crs_reference.md file is obsolete, its still pointing to cluster-api-provider-baremetal! and v1a2 and v1a3 of apis, the crs are non existent in dev-env since I believe |
We have two contradicting opinions it seems. It is the only file in the root of the repo and indeed looks obsolete, so insttead of fixing the link we could delete the whole file? @dtantsur @kashifest |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues close after 30d of inactivity. Reopen the issue with /close |
@metal3-io-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Which problem is this PR solving?
Closes issue: Fix dead links at crs_reference.md #446
Fixes: #446
Description of the changes
Changed from https://github.com/metal3-io/metal3-dev-env/tree/master/crs to https://github.com/metal3-io/metal3-dev-env/tree/b5a53ecf9576c6deab81f692733782d4c5e8091a/crs
How was this change tested?
Ensured the link works both on Browser and when clicked on the Doc.